Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Fix dapp store deployment #3829

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Fix dapp store deployment #3829

merged 3 commits into from
Aug 2, 2023

Conversation

raymondjacobson
Copy link
Member

Description

Fix issues in dapp store deployment
Screenshot 2023-08-01 at 12 49 35 AM

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

none

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Via CI with SSH job https://app.circleci.com/pipelines/github/AudiusProject/audius-client/15507/workflows/09109222-1a77-4691-888d-09545a3d6447/jobs/146436

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

next release

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

n/a

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/rj-fix-dapp-store

Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im realizing i think this wont work cause we need to update the versionCode in android manifest manually like we do with android build. do you know what im referring too?

@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 2, 2023
@raymondjacobson
Copy link
Member Author

Im realizing i think this wont work cause we need to update the versionCode in android manifest manually like we do with android build. do you know what im referring too?

Yup done!

@raymondjacobson raymondjacobson merged commit baedc13 into main Aug 2, 2023
2 checks passed
@raymondjacobson raymondjacobson deleted the rj-fix-dapp-store branch August 2, 2023 06:08
raymondjacobson added a commit that referenced this pull request Aug 2, 2023
schottra added a commit that referenced this pull request Aug 3, 2023
* origin/main:
  Add npm run clean script (#3846)
  DMs: Web: Don't nav back when clicking outside the modal (#3844)
  Add prepare step to dapp-store ci flow (#3841)
  [Harmony] Add SelectablePill to Harmony PAY-1654 (#3803)
  [PAY-1688] Mobile: Share track, collection to DMs (#3840)
  Disable upload redesign (#3842)
  Update dapp-store build artifacts
  Update dapp-store build artifacts
  Fix dapp store deployment (#3829)
  [C-2907] Add contextual-menu, refactor release-date-field (#3836)
  [PAY-1687] Web: Share tracks, playlists, and albums via Direct Message (#3828)
  Upgrade sdk to beta.105 to fix rewards claiming (#3839)
  [C-2923] Fix toasts in modal screens (#3838)
  Add cypress upload test for subgenre (#3833)
  [PAY-1685] Wire up stripe UI for USDC purchase in mobile (#3837)
  Fix broken track upload for electronic subgenres on mobile (#3835)
  Fix tag input (#3832)
audius-infra pushed a commit that referenced this pull request Aug 5, 2023
[f9e1380] Add DirectMessages Banner and Update All Banners (#3851) Marcus Pasell
[e523d39] [PAY-1692] Rewrite 'Share to DMs' using less stateful logic (#3852) Marcus Pasell
[af62892] [C-2675][C-2692] Add multi track navigation sidebar and form controls (#3847) Andrew Mendelsohn
[ee38400] Fix send audio flow (#3850) Reed
[bd1752b] Update SDK to latest 3.0.3-beta.109 (#3849) nicoback2
[6988a03] Add npm run clean script (#3846) Reed
[68bd638] DMs: Web: Don't nav back when clicking outside the modal (#3844) Marcus Pasell
[1f7d7d0] Add prepare step to dapp-store ci flow (#3841) Raymond Jacobson
[6c87efd] [Harmony] Add SelectablePill to Harmony PAY-1654 (#3803) nicoback2
[69fbfb3] [PAY-1688] Mobile: Share track, collection to DMs (#3840) Marcus Pasell
[f2f9717] Disable upload redesign (#3842) Andrew Mendelsohn
[9671c06] Update dapp-store build artifacts audius-infra
[77b4030] Update dapp-store build artifacts audius-infra
[baedc13] Fix dapp store deployment (#3829) Raymond Jacobson
[bcb5137] [C-2907] Add contextual-menu, refactor release-date-field (#3836) Dylan Jeffers
[df90566] [PAY-1687] Web: Share tracks, playlists, and albums via Direct Message (#3828) Marcus Pasell
[ec16cc3] Upgrade sdk to beta.105 to fix rewards claiming (#3839) Dylan Jeffers
[270cc2f] [C-2923] Fix toasts in modal screens (#3838) Dylan Jeffers
[18616df] Add cypress upload test for subgenre (#3833) Raymond Jacobson
[8a76f7c] [PAY-1685] Wire up stripe UI for USDC purchase in mobile (#3837) Reed
[6337949] Fix broken track upload for electronic subgenres on mobile (#3835) nicoback2
[f643695] Fix tag input (#3832) Andrew Mendelsohn
[5da8e8f] Update userbank function usage to pass config object (#3823) Randy Schott
[8a5419d] Update dapp-store build artifacts audius-infra
[6284c14] [C-2857] Revert remove get blocknumber (#3802)" (#3826) Dylan Jeffers
[6a54b3a] [C-2742] Multi-track form pagination (#3818) Andrew Mendelsohn
[65471a1] Bump mobile versions for client v1.5.35 full app release (#3827) nicoback2
[6c88515] Revert "Add purchased + reposted tracks to library PAY-1633  (#3820)" (#3825) nicoback2
[8dc4c8a] Add purchased + reposted tracks to library PAY-1633  (#3820) nicoback2
[5ddf078] Update SDK version + ActivityFull type (#3819) nicoback2
[c643b8a] Use audius-query in USDC Purchase Drawer (#3822) Reed
[a119db1] Update bootstrap nodes (#3821) Theo Ilie
[d2630a8] [PAY-1589] Wire up Stripe Onramp in mobile (#3814) Reed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants